Alby96/Europa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark the place the map is pointed at, and make following work

Browse Source 
Choosing a town moved the camera and then left the reader to work out which of
the settlements now on screen was the one they asked for. A town has no precise
position, so the map now marks its centre: a white disc under a coloured dot,
drawn as a style layer so the native renderer keeps it pinned through every pan
and zoom. The radar frames are inserted below it, because a band of rain must
not paint over the one thing that says which town this is.

A searched municipality becomes a PointTarget rather than being thrown away as
"the whole region". It is marked, the recentre button returns to it, and the
chip names it - but it is never persisted, so looking something up no longer
costs the user the place their app opens on. That was a real defect: searching
went through select(FreeTarget), which wrote null over the stored preference.

Following the device was broken outright. MapLibre reports a camera animation
the app started exactly as it reports the user grabbing the map, so engaging
follow and then animating to the position cancelled the follow it had just
started; the resulting FreeTarget then re-framed the whole region. Follow now
moves the camera first and switches tracking on second, and FreeTarget no longer
moves the camera as a reaction to the state changing - framing the region is an
action, so panning away while following keeps the view the user panned to.

Verified on the emulator with a fix in Turin: a searched town is marked and
saveable, the app reopens on it with the marker in place, following centres on
the blue dot, and panning stops the chase without yanking the map away.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Alby96
2026-09-10 23:17:21 +02:00
co-authored by Claude Opus 5
parent f434a68155
commit a686f7625e
7 changed files with 515 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Nuvolari/app/lib/features/map/radar_overlay.dart
+27 -9
View File
@@ -14,13 +14,16 @@ import '../../core/region/geo.dart';
/// GPU memory at once, and twenty 512×512 RGBA frames is about 80 MB. Two
/// buffers cost the same whether the timeline holds six frames or sixty.
class RadarOverlay {
RadarOverlay({required this.map, required GeoBounds bounds})
: _quad = LatLngQuad(
topLeft: LatLng(bounds.north, bounds.west),
topRight: LatLng(bounds.north, bounds.east),
bottomRight: LatLng(bounds.south, bounds.east),
bottomLeft: LatLng(bounds.south, bounds.west),
);
RadarOverlay({
required this.map,
required GeoBounds bounds,
this.belowLayerId,
}) : _quad = LatLngQuad(
topLeft: LatLng(bounds.north, bounds.west),
topRight: LatLng(bounds.north, bounds.east),
bottomRight: LatLng(bounds.south, bounds.east),
bottomLeft: LatLng(bounds.south, bounds.west),
);
static const String _sourceA = 'nuvolari-radar-a';
static const String _sourceB = 'nuvolari-radar-b';
@@ -29,6 +32,12 @@ class RadarOverlay {
final MapLibreMapController map;
/// Layer to insert the frames beneath, or null to put them on top.
///
/// The place marker sits above the weather: a band of rain over the town the
/// user just chose must not hide the thing that says which town it was.
final String? belowLayerId;
/// Corners of the published frames. The worker renders in EPSG:3857 cropped
/// to exactly this box, so the quad is exact and nothing is warped client
/// side.
@@ -57,8 +66,17 @@ class RadarOverlay {
await map.addImageSource(_sourceA, bytes, _quad);
await map.addImageSource(_sourceB, bytes, _quad);
await map.addImageLayer(_layerA, _sourceA);
await map.addImageLayer(_layerB, _sourceB);
final below = belowLayerId;
if (below == null) {
await map.addImageLayer(_layerA, _sourceA);
await map.addImageLayer(_layerB, _sourceB);
} else {
// Both go under the same layer, so which of the two ends up on top of the
// other does not matter: only one is ever visible.
await map.addImageLayerBelow(_layerA, _sourceA, below);
await map.addImageLayerBelow(_layerB, _sourceB, below);
}
await map.setLayerVisibility(_layerB, false);
_attached = true;